smart: Use drive self-assessment as an overall status #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libatasmart attribute overall status differs slightly from the drive SMART self-assessment and is very sensitive for particular status values. Such status should fit more like a pre-fail warning, no reason to fail hard the global assessment. Even a single reallocated sector would cause a warning, while the drive could be quite healthy otherwise.
tomasmatus
added a commit
to tomasmatus/cockpit
that referenced
this pull request
Mar 21, 2025
Libblockdev changed how SmartFailing property is set. Now it is less strict with when disk a is considered as failing. storaged-project/libblockdev#1097
tomasmatus
added a commit
to tomasmatus/cockpit
that referenced
this pull request
Mar 21, 2025
fixes: cockpit-project#21728 Libblockdev changed how SmartFailing property is set. Now it is less strict with when disk a is considered as failing. storaged-project/libblockdev#1097
tomasmatus
added a commit
to tomasmatus/cockpit
that referenced
this pull request
Mar 21, 2025
fixes: cockpit-project#21728 Libblockdev changed how SmartFailing property is set. Now it is less strict with when a disk is considered as failing. storaged-project/libblockdev#1097
tomasmatus
added a commit
to tomasmatus/cockpit
that referenced
this pull request
Mar 24, 2025
fixes: cockpit-project#21728 Libblockdev changed how SmartFailing property is set. Now it is less strict with when a disk is considered as failing. storaged-project/libblockdev#1097
tomasmatus
added a commit
to tomasmatus/cockpit
that referenced
this pull request
Mar 24, 2025
fixes: cockpit-project#21728 Libblockdev changed how SmartFailing property is set. Now it is less strict with when a disk is considered as failing. storaged-project/libblockdev#1097
martinpitt
pushed a commit
to cockpit-project/cockpit
that referenced
this pull request
Mar 25, 2025
fixes: #21728 Libblockdev changed how SmartFailing property is set. Now it is less strict with when a disk is considered as failing. storaged-project/libblockdev#1097
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The libatasmart attribute overall status differs slightly from the drive SMART self-assessment and is very sensitive for particular status values. Such status should fit more like a pre-fail warning, no reason to fail hard the global assessment. Even a single reallocated sector would cause a warning, while the drive could be quite healthy otherwise.